Fix quoting in zsh configuration instructions #998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rtx
is an amazing tool, thank you for it!The configuration instructions emitted by the installation script for configuring
zsh
don't work as written if you don't haveZDOTDIR
set. I think this is a regression that was introduced recently by the changes in #963, which added the quotes, presumably to accommodate the case whereZDOTDIR
includes spaces or other shell special characters.Here's what the instructions currently look like when you install for
zsh
:Trying to run this line:
... results in this:
... because of the fact that
~
doesn't get expanded within double-quotes. The zsh manual says:... so this change falls back to
$HOME
in the case where$ZDOTDIR
is unset.